Bug: No type in schema #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jddarby
reviewed
Feb 23, 2024
Cyclam
reviewed
Feb 26, 2024
Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
Cyclam
added a commit
that referenced
this pull request
Feb 28, 2024
* added nexus arm processor; added nfvi type to vnfinput.json; added condition for calling each arm processor * pipe through nfvi type from vnf input to template; added nexus input; fixed mistakes in armprocessor * initial commit for children vnf handlers * added core and nexus config logic * fixed nexus input and nexus processor; fixed templates * generalised render manifest and render definition bicep functions to use one * added incorrect config error handling * added nexus flag to publish; added error handling for incorrect vnf type (if forgot to put nexus flag case); tidied nexus inputs * added vnf nexus base bicep; fixed vnf definition template; temp fix for image versions * moved render bicep to common/utils; replaced build base bicep with render bicep * general tidyup: removed prints, added return types * added nfvi type to nsds * removed old todos * refactored nexus handler, moved generate params code into processor * moved logic to base vnf handler; moved more logic to processor * fix template name in vnf j2 * fixed nexus image file * added nfvitype to nsd nf template by making new j2 + changing how nfd processor works * added nfvitype to nsd nf template by making new j2 + changing how nfd processor works * minor formatting * made vnfnexus a definition type; slight refactor of custom.py * removed nexus param, removed prints, added commented out test file * fixed flake8 + pylint issues * Base handler treats command inputs separately (#143) * refactored base handler init to treat inputs from different commands separately; added better validation * fixed error handling in base handler * fixed error typing --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * mypy fixes * fixed customLocation id for vnf nexus * markups from review inc moving build manifest to parent vnf handler * added better docstrings * updated history.rst * Achurchard/fix helm chart upload (#144) * Use helm push for Helm charts (not oras push) * Logging --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> * bumped version * Bug: No type in schema (#148) * first fix for anyOf logic error msg * Update src/aosm/azext_aosm/build_processors/base_processor.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/build_processors/base_processor.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Bug: Nexus Image Version Must be Semver (#149) * added semver checking to input config validation; moved split image path to utils * changed semver regex; renamed function * fixed typo * markups * fix typo --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Create RG if it doesn't exist (#150) * add validation resource group exists function * tidied up code * Update src/aosm/azext_aosm/definition_folder/reader/definition_folder.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * renaming from markups --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Bug Fix: NFD and NSD Manifest Names Clash (#147) * added sa_manifest and acr_manifest property, added sa and acr to manifest names; added nsd to nsd manifest name * create manifest name from nf/nsd name instead of acr/sa; fixed docs strings --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix Nexus Linting + Add Unit Tests (#146) * fixed pylint + flake8 errors * fix mypy errors * fixed artifact builder tests * temp commit for unit testing * temp push of broken tests * added new mocks (not perfect) for vnfs£ * fixed artifact write failure * More mypy fixes * fixed style issues --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> * Use ephemeral tempdir for generated helm package .tgz file. (#151) * Use ephemeral tempdir for generated helm package .tgz file. * Fix file_path bug if .tgz file was provided by user. --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.