Overhaul typing support#1104
Closed
jdalrymple wants to merge 62 commits into
Closed
Conversation
jdalrymple
changed the title
Owner
Author
|
So this should technically work, but ill have to update alot more references i think. |
jdalrymple
force-pushed
the
1088-union-typing
branch
2 times, most recently
from
e787947 to
4460a84
Compare
jdalrymple
force-pushed
the
1088-union-typing
branch
from
8e4ab41 to
fcb230f
Compare
Bumps [auto](https://github.com/intuit/auto) from 9.50.1 to 9.52.0. - [Release notes](https://github.com/intuit/auto/releases) - [Changelog](https://github.com/intuit/auto/blob/master/CHANGELOG.md) - [Commits](intuit/auto@v9.50.1...v9.52.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Justin Dalrymple <jdalrymple@users.noreply.github.com>
jdalrymple
force-pushed
the
1088-union-typing
branch
from
fcb230f to
001fbdb
Compare
Owner
Author
|
Having trouble sorting out the typings :( I posted up an example situation on SO to hopefully get some guidance |
Owner
Author
|
Finished the first pass, going to double check what has been added and include supplemental TODO's for the next PR |
Owner
Author
|
Breaking this PR up into cleaner pieces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Played around with conditional typing. Sorta based off this
Specific example here
fixes: #1088 #1306 #1482 #1218 #519
Update
Finally got the typing to work, next steps are:
📦 Published PR as canary version:
29.0.0--canary.1104.301157685.0✨ Test out this PR locally via:
npm install @gitbeaker/browser@29.0.0--canary.1104.301157685.0 npm install @gitbeaker/cli@29.0.0--canary.1104.301157685.0 npm install @gitbeaker/core@29.0.0--canary.1104.301157685.0 npm install @gitbeaker/node@29.0.0--canary.1104.301157685.0 npm install @gitbeaker/requester-utils@29.0.0--canary.1104.301157685.0 # or yarn add @gitbeaker/browser@29.0.0--canary.1104.301157685.0 yarn add @gitbeaker/cli@29.0.0--canary.1104.301157685.0 yarn add @gitbeaker/core@29.0.0--canary.1104.301157685.0 yarn add @gitbeaker/node@29.0.0--canary.1104.301157685.0 yarn add @gitbeaker/requester-utils@29.0.0--canary.1104.301157685.0