Support Python 3.14 #528
Merged
Support Python 3.14 #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
``` tenacity/__init__.py:314: error: Returning Any from function declared to return "dict[str, Any]" [no-any-return] tenacity/__init__.py:322: error: Returning Any from function declared to return "IterState" [no-any-return] Found 2 errors in 1 file (checked 19 source files) ``` Signed-off-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
This refactors the original code to work with Python 3.14, leveraging `asyncio.run()` for automatic event loop management, which is the recommended approach in modern asyncio. Fixes jd#527. Signed-off-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
Related-To: jd#527 Signed-off-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
sandrobonazzola
force-pushed
the
3.14_test
branch
from
ed0d5ef to
82ddf48
Compare
Signed-off-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
Contributor
Author
|
Addressed mergify comment. @jd anything else missing? |
jd
approved these changes
Jun 26, 2025
Contributor
Author
|
@jd is mergify supposed to handle the merge after your approval? It seems it's not really doing it. |
Owner
|
Contributor
Author
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
Contributor
Author
|
@jd looking at |
Owner
|
It's just that you changed the CI list, so it can't be merged automatically, I missed that. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing with Python 3.14: includes fixes for #527 needed to pass.