Make logger more compatible #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
jd
previously requested changes
Apr 26, 2021
Owner
jd
left a comment
jd
left a comment
There was a problem hiding this comment.
Not a fan of this. Loguru not implementing the standard logging interface is their choice but making it paid by every library out there is not an option.
Since in that case, it's not too hard, I'd be ok with this. I'm just worried it'll be broken since there's no test and no easy way to add tests.
Owner
|
@Mergifyio update |
Contributor
|
Command
|
jd
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
str.formatto complete format string internally, this helpstenacityto be more compatible with other loggers such asloguru.Without this PR the logging shows
tenacity.before_sleep:log_it:41 - Retrying %s in %s seconds as it %s %s.when passing in logger from loguru.