Merged
Conversation
Contributor
|
|
Closed
jd
previously requested changes
Apr 26, 2021
|
Good effort, thanks! Please consider specifying the versions for which support is removed right in the commit message. |
Dunedan
reviewed
May 28, 2021
Closed
Contributor
|
Ooh, last update was so long time ago, that I was afraid that it abandoned.
You can borrow next changes from mine pr then: I made several things at
once: drop old + drop compatibility + fix broke mypy annotations (used to
check, that minimally not broken internals) and tested on python up to 3.10
…On Tue, 22 Jun 2021, 20:43 Andrey Semakin, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In setup.cfg
<#293 (comment)>:
> @@ -24,9 +22,7 @@ classifier =
[options]
install_requires =
six>=1.9.0
Yeah, it could be nice. Totally agree but I'd prefer to make it in a
separate PR to keep this one focused. After removing Python 2 dependency we
could have a bunch of other different improvements. Created an issue to not
forget about it: #305 <#305>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#293 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2KMM5GV52Q3TFHXCPY5QDTUDKVZANCNFSM43DJMZDQ>
.
|
and-semakin
marked this pull request as ready for review
June 22, 2021 19:00
Contributor
Author
|
@homeworkprod updated the commit message, now it contains exact Python versions, thanks! |
Contributor
Author
|
@penguinolog, wow, you've done a huge amount of work! Great job! I borrowed a little from your PR. Thanks! |
penguinolog
approved these changes
Jun 22, 2021
Contributor
|
I'll rebase mine changes after merge of this PR |
jd
previously requested changes
Jun 23, 2021
jd
approved these changes
Jun 23, 2021
Contributor
Author
|
Thanks for your thorough review @jd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR obsoletes Python 2.7 & 3.5, removes them from package metadata and CI. Also, it adds the
python_requiresmetadata option which instructspiprunning on older Python versions to find and install the latest suitable release.See #291