Fix iscoroutinefunction check (for both inspect & asyncio) #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263 did not fully solve #224.
current behavior
How to solve
tenacity/tenacity/_asyncio.py
Line 78 in be9bccb
The reason that it passes
asyncio.iscoroutinefunctionis:But it can not pass
inspect.iscoroutinefunctionsince the returnedfnis not anasync deffunction.Through explicitly defining an
asyncfunction (wrapper) intenacity/tenacity/_asyncio.py
Line 75 in be9bccb
one can make it pass both
inspect.iscoroutinefunctionandasyncio.iscoroutinefunction.