Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] Record stop command is recorded #719

Closed
jcubic opened this issue Dec 17, 2021 · 0 comments
Closed

[Regression] Record stop command is recorded #719

jcubic opened this issue Dec 17, 2021 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 17, 2021

Issue summary

Command that runs save_state(false) is recorded, which is not expected.

Expected behavior

save_state(false) stop recording and command that triggered it is not saved

Actual behavior

command is saved

Steps to reproduce

  1. Open Error Page https://terminal.jcubic.pl/404
  2. type record start
  3. type help
  4. type record stop

There are two commands saved in hash.
@jcubic jcubic added the Bug label Dec 17, 2021
jcubic added a commit that referenced this issue Dec 27, 2021
@jcubic
fix record stop command being recorded #719
65b50e5
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 27, 2021
@jcubic jcubic closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic