Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] for animations #611

Closed
2 tasks done
jcubic opened this issue Jul 26, 2020 · 5 comments
Closed
2 tasks done

[API] for animations #611

jcubic opened this issue Jul 26, 2020 · 5 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 26, 2020

I have idea for a new feature for jQuery Terminal

The code for animations is kind of ugly, there should be better API for it.

Maybe

term.echo($.terminal.animation(<Array of Frames>));
  • New Animation interface
  • TypeScript definition
@jcubic jcubic added the feature label Jul 26, 2020
@jcubic
Copy link
Owner Author

jcubic commented Jul 26, 2020

It may require create class for animation, maybe:

term.echo(new $.terminal.Animation(['A', 'B', 'C']));

and Animation class will be handled by renderHandler.

@jcubic
Copy link
Owner Author

jcubic commented Jul 26, 2020

Consider common interface for using on sub classes.

@jcubic
Copy link
Owner Author

jcubic commented Jul 26, 2020

Consider recording of animations of user typing and saving in compact JSON object that can be saved.

@jcubic
Copy link
Owner Author

jcubic commented Aug 1, 2020

Here is the POC https://codepen.io/jcubic/pen/VweodLO?editors=1010 single class that have render method and those methods that can be overwritten in child class.

@jcubic
Copy link
Owner Author

jcubic commented May 23, 2021

Maybe consider rendering on Canvas.

jcubic added a commit that referenced this issue Jul 9, 2021
jcubic added a commit that referenced this issue Jul 9, 2021
jcubic added a commit that referenced this issue Jul 9, 2021
jcubic added a commit that referenced this issue Jul 9, 2021
jcubic added a commit that referenced this issue Jul 9, 2021
jcubic added a commit that referenced this issue Aug 3, 2021
@jcubic jcubic added resolved if issue is resolved, it will be open until merge with master and removed in progress labels Aug 3, 2021
@jcubic jcubic closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant