Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken color CSS vars #575

Closed
jcubic opened this issue May 19, 2020 · 1 comment
Closed

Broken color CSS vars #575

jcubic opened this issue May 19, 2020 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented May 19, 2020

Issue summary

Changing background no longer works

Expected behavior

There is white background

Actual behavior

Greetings have black background

Steps to reproduce

Open https://codepen.io/jcubic/pen/xReWxJ
@jcubic jcubic added the Bug label May 19, 2020
@jcubic
Copy link
Owner Author

jcubic commented May 19, 2020

The problem is CSS specificity the css var don't overwrite original css rules.

jcubic added a commit that referenced this issue May 22, 2020
@jcubic
fix css vars #575
51916d0 
Use same css selectors for default and custom properties so the have same specificity
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 22, 2020
@jcubic jcubic closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic