Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump on click when terminal in focus and page is scrolled down #565

Closed
jcubic opened this issue Mar 22, 2020 · 0 comments
Closed

Jump on click when terminal in focus and page is scrolled down #565

jcubic opened this issue Mar 22, 2020 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 22, 2020

Issue summary

When there is scrollbar on body, you have terminal inside the page, you scroll down and click on terminal it jumps.

Expected behavior

Scrollbar should stay when you click on terminal

Actual behavior

it jumps

Steps to reproduce

  1. go to Terminal Demo an home page
  2. click on terminal and type few enters
  3. scroll down so you don't see top of the terminal but see the prompt and cursor blinking
  4. click on terminal (it jumps)

Browser and OS

Chrome; GNU/Linux
@jcubic jcubic added the Bug label Mar 22, 2020
jcubic added a commit that referenced this issue Apr 18, 2020
@jcubic
fix jumping issue #565
a58908f 
When you scrolled down the terminal the value of top on textarea was negative
so it moved outside of visible area and when you focus on textarea
it was jumping, using Math.max(value, 0) solved the issue
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 27, 2020
@jcubic jcubic closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic