Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSI formatting error #460

Closed
jcubic opened this issue Jan 17, 2019 · 2 comments
Closed

ANSI formatting error #460

jcubic opened this issue Jan 17, 2019 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jan 17, 2019 •
edited
Loading

Steps to reproduce

Render this unix / guy ritchie ansii banner - (It should be Denis).

$.get('https://terminal.jcubic.pl/unix.ans').then($.terminal.active().echo)
@jcubic jcubic added the Bug label Jan 17, 2019
jcubic added a commit that referenced this issue Jan 17, 2019
@jcubic
fix 8bit colors in unix formatting #460
22dbbc2
jcubic added a commit to jcubic/ansidec that referenced this issue Jan 17, 2019
@jcubic
fix related to jcubic/jquery.terminal#460
dabbeaf
@jcubic
Copy link
Owner Author

jcubic commented Jan 17, 2019

It will be challenging to fix, the problem is not in unix_formatting, as I though (but it had bugs). My ansidec based on unix formatting after some tweaks renders Denis Ritchie ANSI art correctly but when I've added it instead of ansi formatting it's still broken. It skip lines.

jcubic added a commit that referenced this issue Jan 19, 2019
@jcubic
fix handling double slash in formatting #460
d599cbd
@jcubic
Copy link
Owner Author

jcubic commented Jan 19, 2019

The problem was this formatting: [[;#EEEEEE;#585858]\][[;#000000;#585858]] first unix_formatting didn't escaped \ in output text second it was not handled correctly in iterate_formatting function used by split_equal. As a bonus I've added one optimization (iterate_formatting was executing even on lines that where shorter then the length of the terminal).

jcubic added a commit that referenced this issue Jan 19, 2019
@jcubic
fix handling slashes + ignore broken ANSI escapes #460
00ba172
jcubic added a commit that referenced this issue Jan 19, 2019
@jcubic
fix handling escaped slashes outsite formatting #460
86c90ff
jcubic added a commit that referenced this issue Jan 19, 2019
@jcubic
don't escape slashes outside formatting in unix formatting + fix tests …
9f2ebd2 
…#460
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jan 19, 2019
@jcubic jcubic closed this as completed Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic