Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Android web clients, first character entered into terminal gets appended by single whitespace #391

Closed
aborovac opened this issue May 3, 2018 · 4 comments
Closed

On Android web clients, first character entered into terminal gets appended by single whitespace #391

aborovac opened this issue May 3, 2018 · 4 comments

Comments

@aborovac
Copy link

aborovac commented May 3, 2018

Expected behavior

Don't append anything

Actual behavior

Appends whitespace to first character entered into terminal

Steps to reproduce

  1. Open terminal demo template at http://codepen.io/jcubic/pen/MbVMwO
  2. enter whatever into terminal

Browser and OS

Dolphin, Chrome on Android
@aborovac aborovac changed the title On Android web clients character entered into terminal get appended by single whitespace On Android web clients, character entered into terminal gets appended by single whitespace May 3, 2018
@aborovac aborovac changed the title On Android web clients, character entered into terminal gets appended by single whitespace On Android web clients, first character entered into terminal gets appended by single whitespace May 3, 2018
@jcubic
Copy link
Owner

jcubic commented May 3, 2018

it seems that this happen only to the first character afer you focus on the terminal

jcubic added a commit that referenced this issue May 3, 2018
@jcubic
fix fix space after first character #391
827ada8
@jcubic
Copy link
Owner

jcubic commented May 3, 2018

Fixed in devel branch, the problem was the hack that insert space at the beginning for select all context menu. I didn't put space correction code in insert event that is used on android.

@aborovac
Copy link
Author

aborovac commented May 3, 2018 •
edited
Loading

works well. thanks.

@jcubic
Copy link
Owner

jcubic commented May 13, 2018

in version 1.15.0

@jcubic jcubic closed this as completed May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcubic @aborovac