This repository was archived by the owner on Nov 21, 2025. It is now read-only.
DatabaseWrapper: First draft of achieving independency from locales#20
Open
Andrei-Errapart wants to merge 11 commits intojchristn:masterfrom
Open
DatabaseWrapper: First draft of achieving independency from locales#20Andrei-Errapart wants to merge 11 commits intojchristn:masterfrom
Andrei-Errapart wants to merge 11 commits intojchristn:masterfrom
Conversation
…verting everything to string. Only DatabaseWrapper.SqlServer has been modified at this point.
…lauses corrected.
…ToWhereClause. Thanks to using sql parameters it is almost generic now.
Author
|
…TimestampFormat and TimestampOffsetFormat.
Author
|
At first sight it seems to work with RestDb. |
Owner
|
Hi @Andrei-Errapart sorry for the delay on getting back to you on this one, I will do my best to get to it ASAP. I appreciate your contribution! |
Author
|
Anything that speaks against simply closing it? Just to be sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to be solved
As present the DatabaseWrapper at least regarding MS Sql Server is dependent on the database on the SQL server having the same regional settings as DatabaseWrapper. The problem becomes worse when there are multiple databases with different locales.
Corresponding issue:
#17
Solution
The solution resolves the problem by using parametrized SQL queries. The amount of code is about the same as when sanitizing all the inputs.
Let me note that the reduction of lines of code in DatabaseWrapper.SqlServer was not due to conversion to use parametrized SQL queries.
As soon as the SQL query parametrization is OK for DatabaseWrapper.SqlServer, I will implement it for other drivers, too.
I am all ears for the improvements.