Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect operating system and adjust hold key options #43

Closed
jchang504 opened this issue Jun 7, 2017 · 3 comments
Closed

Auto-detect operating system and adjust hold key options #43

jchang504 opened this issue Jun 7, 2017 · 3 comments

Comments

@jchang504
Copy link
Owner

For example, remove the ContextMenu option (the context menu key only appears on non-Mac keyboards -- and not even on all of them) when the user is on a Mac, and label the Meta value as Cmd for Mac, Windows key for Windows. Parsing the output of this seems to be the way to do it.

@carbon-steel
Copy link
Collaborator

I think this is a little more important than P3 because the current interface is a little confusing with the parentheticals in choosing the hold key.

@carbon-steel carbon-steel added P2 and removed P3 labels Jun 10, 2017
@jchang504
Copy link
Owner Author

Can we alternatively fix that by just improving the clarity of the UI for now? I have #20 marked as part of the release milestone, so we are definitely going to overhaul the options page UI.

@jchang504
Copy link
Owner Author

Now that the new approach to handling the hold key is going to be implemented, this auto-detection (and setting the hold key to a OS-specific default) is now much more important, because some of the hold key choices are terrible for certain OSes. In fact, we should maybe just force the hold key choice and only make it customizable in advanced/experimental settings (#49).

@jchang504 jchang504 added P1 and removed P2 labels Jul 24, 2017
@jchang504 jchang504 added this to the v1.0.0 Release Ready milestone Jul 24, 2017
@jchang504 jchang504 self-assigned this Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants