Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make last tab tracking include all tab changes, not just from KeepTabs #39

Closed
jchang504 opened this issue Jun 5, 2017 · 1 comment
Closed

Make last tab tracking include all tab changes, not just from KeepTabs #39

jchang504 opened this issue Jun 5, 2017 · 1 comment
Assignees
@jchang504
Labels
feature P2 simple

Comments

@jchang504
Copy link
Owner

Implement this suggestion on #14 using https://developer.chrome.com/extensions/tabs#event-onActivated.
@jchang504 jchang504 self-assigned this Jun 5, 2017
@jchang504
Copy link
Owner Author

As noted in the commit message for 24cac2c, this regresses on one small behavior specified at the end of this comment and implemented in 284e3de, but I'm not terribly upset about it since it's such an obscure use case and not an incredibly disruptive difference.

@carbon-steel carbon-steel mentioned this issue Jun 10, 2017
Closed
carbon-steel pushed a commit that referenced this issue Jun 11, 2017
@jchang504
Track all tab changes for last_tab_id (closes #39)
ccea040 
Use an onActivated listener to update last_tab_id every time the active tab is
changed, not just when it's through KeepTabs. This does break one small
behaivor: before when the user opened tab search with the hotkey, then manually
closed tab search without selecting a tab, the last tab would be saved as the
tab that tab search was launched from. Now, it's saved as the tab search tab
(which has been closed), so trying to navigate to the previous tab doesn't do
anything. But this is a pretty obscure use case (you shouldn't really be
manually cancelling searches often), and it's not even that big a disruption
when it happens, so I'm fine with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchang504 jchang504

Labels
feature P2 simple
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchang504