Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between URL's that have the same domain name #24

Closed
carbon-steel opened this issue Apr 9, 2017 · 2 comments
Closed

Differentiate between URL's that have the same domain name #24

carbon-steel opened this issue Apr 9, 2017 · 2 comments

Comments

@carbon-steel
Copy link
Collaborator

I set the hotkey 'to' to "https://www.toggl.com/app" and the hotkey 'm' to "https://www.facebook.com/messages". When I use the hotkeys to construct a new tab, they take me to the correct URL's. However, if there is a tab that has the same domain name (but not the same path aka the rest of the URL), the extension will just take me to that tab, which is incorrect.

Ex: using hotkey 'm' would take me to the already open tab that has the URL 'https://www.facebook.com/' even though I want to open a new tab with the complete URL that I had set.

@jchang504
Copy link
Owner

jchang504 commented Apr 9, 2017

This is not necessarily incorrect, but certainly the more specific matching is a useful behavior. But more general domain matching is useful too, e.g. when you do want to navigate to whichever Facebook page you happen to have open. I think we should redesign the hotkey configuration a little to add a field for what should be counted as a match for a given hotkey (note this is only when deduplicate is checked). So the entry in options would look something like:

Hotkey | Target URL | Deduplicate? [Matches]

Where the Matches input would only appear when Deduplicate is checked.

@carbon-steel
Copy link
Collaborator Author

Closing this issue was an accident

@carbon-steel carbon-steel reopened this Jun 29, 2017
@jchang504 jchang504 modified the milestone: v1.0.0 Release Ready Jun 30, 2017
@jchang504 jchang504 assigned jchang504 and unassigned carbon-steel Jul 1, 2017
jchang504 added a commit that referenced this issue Jul 1, 2017
This commit simply restructures the options as stored in Chrome storage for the
upcoming implementation of #24. It includes code to load the old structure of
options from storage and fill them into the new structure. Before this legacy
code can be removed, all active users (to avoid losing their options) should
pull this commit, open KeepTabs options, and Save All (you can change something
and change back to enable the save button).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants