see #63 adds multipart upload functions #64
Conversation
There was a problem hiding this comment.
Thanks so much for this @cybersonic! I am really happy to be adding multipart upload support. I did have some cleanup requests if you have time. I'd like this in the library, so I am going to merge it in any case 😁
services/s3.cfc
Outdated
| for ( | ||
| var key in arguments | ||
| ) { | ||
| // if ( len( arguments[ key ] ) ) queryParams[ utils.parseKey( key ) ] = arguments[ key ]; |
There was a problem hiding this comment.
I take it nothing from the arguments needs to go into the query string? Should this be removed then?
services/s3.cfc
Outdated
| '/#arguments.Key#', | ||
| queryParams, | ||
| { | ||
| // "x-amz-acl": "public-read" |
There was a problem hiding this comment.
Yeah! Will remove in my next PR!
services/s3.cfc
Outdated
|
|
||
| ){ | ||
| var requestSettings = api.resolveRequestSettings( argumentCollection = arguments ); | ||
| dump("putPart"); |
services/s3.cfc
Outdated
| for ( | ||
| var key in arguments | ||
| ) { | ||
| // if ( len( arguments[ key ] ) ) queryParams[ utils.parseKey( key ) ] = arguments[ key ]; |
There was a problem hiding this comment.
Same question as above, looks like this argument key loop isn't necessary?
There was a problem hiding this comment.
Looks like I had a copy pasta frenzy! removing!
services/s3.cfc
Outdated
| '/#arguments.Key#', | ||
| queryParams, | ||
| { | ||
| // "x-amz-acl": "public-read" |
There was a problem hiding this comment.
Yeah, I was debugging hard here :)
services/s3.cfc
Outdated
| ); | ||
|
|
||
| if ( apiResponse.statusCode == 200 ) { | ||
| // apiResponse[ 'data' ] = utils.parseXmlDocument( apiResponse.rawData ); |
There was a problem hiding this comment.
I don't know what the api response looks like here, is it an XML document? If not, can this 200 check be removed?
There was a problem hiding this comment.
Yeah, it should be XML for the most part.
There was a problem hiding this comment.
Actually in this case it just returns headers rather than any body content so I had to remove the XML Parsing
services/s3.cfc
Outdated
| "uploadId": arguments.UploadId | ||
| }; | ||
| for ( | ||
| var key in arguments |
There was a problem hiding this comment.
Same question again regarding the argument loop 😄
services/s3.cfc
Outdated
| ); | ||
|
|
||
|
|
||
| if ( apiResponse.statusCode == 200 ) { |
There was a problem hiding this comment.
Same question regarding the response status check.
services/s3.cfc
Outdated
| required string Key, | ||
| required numeric partNumber, | ||
| required string uploadId, | ||
| // required string ContentType, |
There was a problem hiding this comment.
REmoved. I thought it was needed as part of the signing but apparently not.
|
Do you want to push your changes? :) |
|
Done! |
|
Thank you! |
This PR adds the following functions:
createMultipartUpload
putPart
completeMultipartUpload
generatePresignedURLForPart
Which allow for multipart uploads