Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting whats-new.rst for doc-building #366

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

JoranAngevaare
Copy link
Contributor

@JoranAngevaare JoranAngevaare commented Jun 26, 2024

Fix documentation building

This is probably more related to one sub-packages of sphinx that is actually causing the issue, but I think this should do the trick to get the documentation building back up.

New page is on:
https://cmip6-preprocessing--366.org.readthedocs.build/en/366/whats-new.html

  1. First try (6474e49) did look to kind of bad looking information:
    image

  2. Second try (de712ae) also yielded something horrible
    image

  3. The third try (fdbe8c3) actually fixes the issue
    image

  4. The fourth commit fixes the strange rst syntax which no one remembers ef138c9. Now the hyperlinks to the authors work.
    image

  5. Commit nr. 5/6 adds this PR to the whats-new.rst

@JoranAngevaare JoranAngevaare changed the title Fix integer formatting whatsnew for doc-building Fix formatting whatsnew.rst for doc-building Jun 26, 2024
@JoranAngevaare JoranAngevaare changed the title Fix formatting whatsnew.rst for doc-building Fix formatting whats-new.rst for doc-building Jun 26, 2024
@JoranAngevaare JoranAngevaare changed the title Fix formatting whats-new.rst for doc-building Fix formatting whats_new.rst for doc-building Jun 26, 2024
@JoranAngevaare JoranAngevaare changed the title Fix formatting whats_new.rst for doc-building Fix formatting whats-new.rst for doc-building Jun 26, 2024
@JoranAngevaare JoranAngevaare marked this pull request as ready for review June 26, 2024 10:33
@JoranAngevaare JoranAngevaare mentioned this pull request Jun 26, 2024
Copy link
Owner

@jbusecke jbusecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for digging into this @JoranAngevaare!

@jbusecke jbusecke merged commit d3b05dd into jbusecke:main Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants