-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add longitude_bnds
and latitude_bnds
to cmip_renaming_dict
#300
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5672eee
Add `longitude_bnds` and `latitude_bnds` to `cmip_renaming_dict`
JoranAngevaare e26e301
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2ac80b8
Dummy commit
jbusecke e720656
Merge branch 'jbusecke:main' into patch-1
JoranAngevaare f0ff7d2
Add PR To whatsnew
JoranAngevaare eff95dc
write test
JoranAngevaare e031c8c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a6a5835
remove odd rename
JoranAngevaare 3b1b611
Merge branch 'patch-2' of https://github.com/JoranAngevaare/xMIP into…
JoranAngevaare 7692872
Dummy bump
JoranAngevaare 15fd635
revert a6a5835
JoranAngevaare 4d34106
Update whats-new.rst
jbusecke 7fe9a3b
Update drift_removal.py
jbusecke 47dfd09
Merge branch 'main' into patch-1
jbusecke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbusecke this is the line I mentioned, so from the
cmip6_renaming_dict
, you were renamingbnds
tobnds
. But okay, I'll revert a6a5835 - maybe that is safer.