clean up stylelint rules

.stylelintrc

@@ -1,6 +1,47 @@
 plugins:
   - stylelint-scss
 rules:
+  color-no-invalid-hex: true
+  function-calc-no-invalid: true
+  string-no-newline: true
+  unit-no-unknown: true
+  property-no-unknown:
+    - true
+    # Used in css modules
+    - ignoreProperties:
+      - composes
+  block-no-empty: true
+  selector-pseudo-class-no-unknown:
+    - true
+    # Used in css modules
+    - ignorePseudoClasses:
+      - local
+      - global
+  selector-pseudo-element-no-unknown: true
+  media-feature-name-no-unknown: true
+  at-rule-no-unknown:
+    - true
+    # Sass related mixins
+    - ignoreAtRules:
+      - include
+      - mixin
+      - if
+      - else
+      - each
+      - extend
+      - function
+      - return
+      - for
+  comment-no-empty: true
+  no-duplicate-at-import-rules: true
+  no-duplicate-selectors: true
+  no-extra-semicolons: true
+  alpha-value-notation: number
+  color-named: never
+  length-zero-no-unit: true
+  no-eol-whitespace: true
+  max-empty-lines: 1
+  # no-descending-specificity: true
   number-leading-zero: never
   color-hex-case: upper
   string-quotes: single
@@ -40,4 +81,4 @@ rules:
   # camelCase mixin, function, and variable names
   scss/at-mixin-pattern: "^[a-z][a-zA-Z0-9]+$"
   scss/at-function-pattern: "^[a-z][a-zA-Z0-9]+$"
-  scss/dollar-variable-pattern: "^[a-z][a-zA-Z0-9]+$"
+  scss/dollar-variable-pattern: "^[a-z][a-zA-Z0-9]+$"

packages/kbn-optimizer/src/__fixtures__/mock_repo/plugins/bar/public/index.scss

@@ -1,3 +1,4 @@
 body {
+  /* stylelint-disable-next-line color-named */
   color: green;
 }

packages/kbn-optimizer/src/__fixtures__/mock_repo/plugins/bar/public/legacy/_other_styles.scss

@@ -1,3 +1,4 @@
 p {
+  /* stylelint-disable-next-line color-named */
   background-color: rebeccapurple;
 }

src/plugins/advanced_settings/public/management_app/_advanced_settings.scss

@@ -29,11 +29,11 @@
 
   &--unsaved .mgtAdvancedSettings__fieldTitle {
     // Simulates a left side border without shifting content
-    box-shadow: -$euiSizeXS 0px $euiColorWarning;
+    box-shadow: -$euiSizeXS 0 $euiColorWarning;
   }
   &--invalid .mgtAdvancedSettings__fieldTitle {
     // Simulates a left side border without shifting content
-    box-shadow: -$euiSizeXS 0px $euiColorDanger;
+    box-shadow: -$euiSizeXS 0 $euiColorDanger;
   }
 
   @include internetExplorerOnly {
@@ -57,7 +57,7 @@
 
 .mgtAdvancedSettingsForm__unsavedCountMessage {
   // Simulates a left side border without shifting content
-  box-shadow: -$euiSizeXS 0px $euiColorWarning;
+  box-shadow: -$euiSizeXS 0 $euiColorWarning;
   padding-left: $euiSizeS;
 }
 

src/plugins/charts/public/static/components/legend_toggle.scss

@@ -17,4 +17,3 @@
     top: 0;
   }
 }
-

src/plugins/dashboard/public/application/embeddable/panel/_dashboard_panel.scss

@@ -8,7 +8,7 @@
 
 // Adjust borders/etc... for non-spaced out and expanded panels
 .dshLayout-withoutMargins,
-.dshDashboardGrid__item--expanded { 
+.dshDashboardGrid__item--expanded {
   .embPanel {
     box-shadow: none;
     border-radius: 0;

src/plugins/dashboard/public/application/top_nav/panel_toolbar/panel_toolbar.scss

@@ -6,7 +6,7 @@
 .panelToolbarButton {
   line-height: $euiButtonHeight; // Keeps alignment of text and chart icon
   background-color: $euiColorEmptyShade;
-  
+
   // Lighten the border color for all states
   border-color: $euiBorderColor !important; // sass-lint:disable-line no-important
 }

src/plugins/data/public/ui/filter_bar/_global_filter_group.scss

@@ -1,6 +1,6 @@
 // SASSTODO: Probably not the right file for this selector, but temporary until the files get re-organized
 .globalQueryBar {
-  padding: 0px $euiSizeS $euiSizeS $euiSizeS;
+  padding: 0 $euiSizeS $euiSizeS $euiSizeS;
 }
 
 .globalQueryBar:first-child {

src/plugins/data/public/ui/shard_failure_modal/_shard_failure_modal.scss

@@ -5,7 +5,7 @@
 }
 
 .shardFailureModal__desc {
-  // set for IE11, since without it depending on the content the width of the list 
+  // set for IE11, since without it depending on the content the width of the list
   // could be much higher than the available screenspace
   max-width: 686px;
 }
@@ -24,16 +24,16 @@
 }
 
 @include euiBreakpoint('xs','s') {
-  .shardFailureModal__keyValueTitle { 
+  .shardFailureModal__keyValueTitle {
     display: block;
     width: 100%;
   }
-   
+
   .shardFailureModal__descTitle {
     display: block;
     width: 100% !important;
   }
-    
+
   .shardFailureModal__descValue {
     display: block;
     width: 100% !important;

src/plugins/discover/public/application/angular/doc_table/components/table_row/_details.scss

@@ -22,4 +22,3 @@
     border-top: none !important;
   }
 }
-

src/plugins/embeddable/public/lib/panel/_embeddable_panel.scss

@@ -168,5 +168,6 @@
 .embPanel__content[data-loading] {
   pointer-events: none;
   filter: grayscale(100%);
+  /* stylelint-disable-next-line color-named */
   filter: gray;
 }

src/plugins/home/public/application/components/_solutions_section.scss

@@ -66,11 +66,6 @@
   overflow: hidden;
 }
 
-.homSolutionPanel__header {
-  color: $euiColorEmptyShade;
-  padding: $euiSize;
-}
-
 .homSolutionPanel__icon {
   background-color: $euiColorEmptyShade !important;
   box-shadow: none !important;
@@ -93,6 +88,8 @@
 }
 
 .homSolutionPanel__header {
+  color: $euiColorEmptyShade;
+  padding: $euiSize;
   background-color: $euiColorPrimary;
   background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAQYAAAFjCAYAAADfDKXVAAAACXBIWXMAABYlAAAWJQFJUiTwAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAfiSURBVHgB7d1JblRZGobh45SrhJiWGOQ6EENLSKyABTBmOcwRq2EnTKtUdInBuEln/OkMdB3HTTjiNqd5HinA3YBUSq++24UPUkq/J+jE+/fv09HRURrD27dv0+vXr1OLfksAG4QByAgDkBEGICMMQEYYgIwwABlhADLCAGSEAcgIA5ARBiAjDEBGGICMMAAZYQAywgBkhAHICAOQEQZg05/CAGy6FAYgIwzApnNhADLCAGy6EAZgkzAAGVclgIyTj0DGYgAyZ8IADP2ZLAZgw1n8IQzA0Hn8IQzA0EX8IQzAkEMJICMMwDURhcv44DDBlp4+fZrevHmTxvLq1av04cOHRDHO1h8IA1t7/PhxOjo6SjTrdP2BQwlg7ddiEAYgxGXK8/UnwgCEs+EnwgCEk+EnwgCE0+EnwgDEYcTF8AvCAJxufkEYgO+bXxAG6Nu1y5RrwgB9O7npi8IAfTu+6YvCAP3KrkasCQP06/i2bwgD9Ov0tm8IA/QpLlFe3PZNYYA+/bjrm8IA/YmTjqd3/YAwQH+O7/sBYYC+xHmFH/f9kDBAX/7Y5oeEAfqx1VoIwgD9+L7tDwoD9GHrtRCEAfoQ5xYutv1hYYD2PWgtBGGA9m11JWJIGKBtD14LQRigbf9POxAGaNedT1DeRRigTRGEb2lHwgBtetDlyU3CAO35mXY44TgkDNCWy9XrS9qTMEBb9jqEWBMGaEdchbj3TVi2IQzQhr2uQmwSBmjD5zTCIcSaMED94rzCaRqRMEDd4tLkaIcQa8IA9YpDh70vTd5EGKBOcb9CPCA12nmFIWGAOo16snGTMEB94mTjSZqQMEBdIgqjn2zcJAxQj7ircfIoBGGAOsTtzl/TTIQByhe/nXqSy5K3EQYoW0Rhp/dt3MdhAkoVdzV+Slf3LMxKGKBMcU5h1sOHIYcSUJ5FoxAsBijLLPcp3EcYoBxxOXKUd2DalzDA8uLk4sc08nsq7EMYYFnxINRkT0nuShhgOfEgVDwlOfvlyPsIAyyjmPMJNxEGmFccMsRKKOZ8wk2EAeZT7KHDJmGA6UUI4v6EYg8dNgkDTCued4i7GIu66nAfYYBpVLcShoQBxlflShgSBhhP1SthSBhgHNWvhCFhgP00sxKGhAF29OTJkyKfcxiDN2qBHb18+TIOH5qLQhAGICMMQEYYgIwwABlhADLCAGSEAcgIA5ARBiAjDEBGGICMMNCTy0ePHhX/RqwlEAZ6EQ88/e/Zs2dniXt57JrWNfl+CVMTBloW6+BTavTR6CkJA62KlfAtsRNhoDWxEr788zc7EgZaYiWMRBhogZUwMmGgdlbCBISBWlkJExIGamQlTEwYqImVMBNhoBZx5+LXxCyEgdLFXYufV6/TxGyEgZLFSojzCZ6InJkwUCIrYWHCQGmshAIIA6WwEgoiDJTASiiMMLCYw8NDK6FQ3tqNxbx79+5jEoUiCQOLef78uUOHQgkDkBEGICMMQEYYgIwwABlhADLCAGSEAcgIA5ARBiAjDEBGGNjWxYsXL/5IdOFg9fo9wd3+fr+Ey8vLf63+/k8az38PDg5m/RX1q/+G+Pf/O43j++rf/yU1yPsxcBfvl9ApYeA23lWpY8LAJisBYeAaK4G/CQMhQhAr4SRBEgauYhBRsBL4RRj6ZSVwK2Hok5XAnYShL1YCWxGGflgJbE0Y2mcl8GDC0DYrgZ0IQ5usBPYiDO35uXrFE3+zPrVIW4ShHbES4nbm4wR7EoY2WAmMShjqZiUwCWGol5XAZIShPlYCkxOGulgJzEIY6mAlMCthKJ+VwOyEoVxWAosRhjJZCSxKGMpiJVAEYSiHlUAxhGF5VgLFEYZlWQkUSRiWYSVQNGGYn5VA8YRhPlYC1RCGeVgJVEUYpmUlUCVhmI6VQLWEYXxWAtUThnFZCTRBGMZhJdAUYdiflUBzhGF3VgLNEobdnK1en5KVQKOE4eFiJXxL0DBh2F6shC///A1NE4btWAl0RRjuZiXQJWG4nZVAt4QhZyXQPWG4zkqAJAxrVgIMCMPVnYtfE/BLz2GIuxY/r16nCbim1zDESojzCZeJ3sTh4lj/389To3oLg5XQuYODA4eNW+gpDFYCbKmHMFgJ8ECth8FKgB20GgYrAfbQYhisBNhTS2GwEmAkrYTBSoAR1R4GKwEmUHMYrASYSI1hsBJgYrWFwUqAGdQSBisBZlRDGKwEmFnJYbASYCGlhsFKgAWVFgYrAQpQUhisBChECWGwEqAwS4fBSoACLRUGKwEKtkQYrAQo3JxhsBKgEnOFwUqAikwdhghBrISTBFRjyjBEDCIKVgJUZoowOJcAlRs7DM4lQAPGCsPP1etbshKgCfuGIQ4bYiH8SEAzdg1DHCrEQjhODhugOQ8NgyBAB7YNgyBAR+4LgyBAh24Lg6sM0LFhGGIRfE9XdywKAnQswrBeB2fJ4QKQrsLwMQEM/JYANggDkBEGICMMQEYYgIwwABlhADLCAGSEAcgIA5ARBiAjDEBGGICMMAAZYQAywgBkhAHICAOQEQYgIwxARhiAjDAAGWEAMg/9bdf0LX4h0XkCAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACq8hdouPfUCk+KHQAAAABJRU5ErkJggg=='),
     url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAWgAAAFKCAYAAAAwgcXoAAAACXBIWXMAABYlAAAWJQFJUiTwAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAjGSURBVHgB7d27ctRaFoDh1WBzsQ9wLkVsngHHfglSIOUdgJQiJSfmIUjhJUwGjiGaU7hmzoB7vLA1GPCt21vSlvR9Vao+5lAFbbf+EktbUgQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABUaxYAEzCfz/NldX9biTK+zGaz/0aLSv1FAYbg6v52I8r4e39rNdCXAoAqCTRApQQaoFICDVApgQaolEADVEqgASol0ACVEmiASgk0QKUEGqBSAg1QKYEGqJRAA1RKoAEqJdAAlRJogEp5ogowJV/3t/9EGV8DAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFjELABOMZ/Po6TZrL/sDO29rATA6Vb3t/UoY29/+1f04DDO1w63Ev59uLVGoIGz5GHi9Sjja/QU6EPZvFLv5Uu07FIAUCWBBqiUQANUSqABKiXQAJUSaIBKCTRApQQaoFICDVApgQaolEADVEqgASol0ACVEmiASgl0ANRJoAEqJdAAlfJEFeAs+RSUv6OMsg8FXNw/Ue69/BMAAAAAAAAAAAAAAAAAAAAAQCdmAcBpspNn3flzL1q4EZRAA2PRhLR5vXz4683ryk+/7+j/ixO+vqiM9t6Rr78e899ffvq9za9/FWigdhnNbNVqfA/wyuHr5fgxxqMi0EDfMq4Z3ya4K4fbaMN7XgINdKGJ8OUjW/M1JxBooKSj4c3X5mhYa5bgmwYsoxlHXA0hbo1vJnCW5gRds10Jo4lOCDTws4xvRjiPjvOoeDXohUDDtB09Or4W31dTUAE/CJiWJshNjK8E1RJoGDdBHjCBhvHJCBtZjIAfHAxf7scZ46uHr/brkfCDhGFqVllcCWOL0RJoGIajs+S16Hjfnc3K/XHzefG7cp7b0N6HQEO9qhhdbG5uxosXL6KET58+xb1796IPGef79+/Ho0ePooSXL1/Gq1evok0rAdSkiXIeJVdxgm9tbS22traihJ2dnejTxsZGsffy+vXraJtAQ/+qizJ1EGjoRzNTvhGizAkEGrqVKy56OdHH8Ag0tC9vPpRBXg9RZgECDe3IEGeU82jZOmWWItBQlhEGxQg0XFyG+Lc4CLN9imJ8mGB5ebScc+W8kMTRMsUJNCzGbJnOCDScj5UYdE6g4XR5lHwjHC3TA4GGXx299FqY6Y1Aw3fNagxjDKog0CDMVEqgmbIcX+QY43pAhQSaKXLij0EQaKZEmJfU52OqShvSexFopkCYL2B7ezsePnwYJezu7kZfMsz5FJQPHz5ECe/evYu2OSHCmAkzgybQjJEwMwoCzZgIM6Mi0IxB3ifjZhxc/QejIdAMWX5+84h5PWCEBJohcuUfk+DDzdBklPOo2WeX0fMhZyjyxN/vcTBvhkkQaGq3GgcnAK3MYHIEmlo5AcjkCTQ1MmeGsANQlxxj5DhjNQCBpgr5ObwV7ssMPxBo+macASewU9AX982AMwg0XbM6A85JoOmSi01gAQJNF9xtDpYg0LTNSUBYkp2GtuRRc44znASEJQk0bXDUDAXYgSjJUTMUJNCU4qgZCrMzcVGOmqElAs1F5LK5jLPPEbTAjsUyXA0IHRBoFuVqQOiIQLOIPGr+LZic2axcKubzefSl5PtIbb+XSwFny6Plv0KcJ2lrayv29vaKbO/fv4++ZJyfPHlS7L08fvw42rYScDonAqEnAs1JnAiEngk0x8mRxh/h2YDQK4HmZ2txcGtQIw3omUBzVIbZSAMqIdAkIw2okEDjwhOolEBPW44zbgZQJYGepjwBeGt/ux5AtQR6epqrAo00oHICPS05b/4zLKGDQRDo6TBvhoER6GmwvhkGSKDHzfpmGDCBHi8nA2HgBHqcnAyEERDo8XEyEEZCoMfFI6loRZ+PqSptSO/FP4HHI++n4cpAWrGxsRGl7OzsRF/W1tbi9u3bUcLHjx9jd3c32iTQw5c/wzwZaKUGjIxAD5uVGjBiAj1c4gwjJ9DDlOOMjLOfH4yYHXx4PDMQJsJOPiwZ51sBTIJAD4c1zjAxAj0M4gwTJND1E2eYKIGum/s4w4QJdL1cug0TJ9B1EmdAoCskzsA3Al0XcQb+T6DrIc7ADwS6DuIM/EKg+yfOwLEEul/iDJxIoPsjzsCpLgV9yCsExRk4lUB3L++t4fJt4ExGHN1y4yPg3AS6O+IMLESguyHOwMLMoNuXj6kSZ2BhAt2ua+EZgsCSBLo9q3Gw1hlgKStBGy7vb3+EGT8jsL6+Hpubm1HK27dvoy8bGxvfthJ2dna+bW0S6PIyzn8dvsLg3b17N968eRMlZNDu3LkTfZjNZvHgwYN49uxZlPD06dN4/vx5tMmIo6w8YhZnoAiBLuvPEGegEIEuJ++vcSUAChHoMtxfAyhOoC8uw+xCFKA4gb6YXOt8MwBaINDLa9Y6A7RCoJdjOR3QOoFeTl7CLc5AqwR6cbli41oAtEygF2PFBtAZgT4/KzaATgn0+VixAXROoM8n4+ykINApgT5bjjVWA6BjAn269XCPDaAnAn2yHGk4KQj8Yj6fRxc8UeV4zVNRYPJ2d3dje3s7Smj7EVFn+fz5c5H3koHO70vbPDPveHlS0MUoQK+MOH7lSkGgCgL9o3wiiisFgSoI9Hc5d/49ACoh0N+5Qx1QFYE+kHNnD3wFqiLQ5s5ApaYeaHNnoFpTD3SONsydgSpNOdB5j43rAVCpqQbafTaA6k010O6zAVRvioE2dwYGYWqBtqQOGIwpBdqSOmBQphRoow1gUKYS6OthSR0wMFMIdB413wiAgZlCoI02gEEae6CNNoDBGnOgjTaAQRtzoI02gEEba6CNNoDBG2OgZ2G0AYzA/wBP5hsF50HhogAAAABJRU5ErkJggg==');

src/plugins/kibana_legacy/public/paginate/_paginate.scss

@@ -54,4 +54,3 @@ paginate {
     }
   }
 }
-

src/plugins/kibana_react/public/markdown/_markdown.scss

@@ -18,7 +18,6 @@ $kbnDefaultFontSize: 14px;
 }
 
 .kbnMarkdown__body {
-
   // Font size variables
   $kbnMarkdownFontSizeS: canvasToEm(12px);
   $kbnMarkdownFontSize: canvasToEm(14px);
@@ -34,14 +33,14 @@ $kbnDefaultFontSize: 14px;
   $kbnMarkdownSizeXXS: canvasToEm(4px);
 
   // Grayscale variables
-  $kbnMarkdownAlphaLightestShade: rgba($euiColorFullShade,.05);
-  $kbnMarkdownAlphaLightShade: rgba($euiColorFullShade,.15);
-  $kbnMarkdownAlphaDarkShade: rgba($euiColorFullShade,.65);
+  $kbnMarkdownAlphaLightestShade: rgba($euiColorFullShade, .05);
+  $kbnMarkdownAlphaLightShade: rgba($euiColorFullShade, .15);
+  $kbnMarkdownAlphaDarkShade: rgba($euiColorFullShade, .65);
 
   // Reverse grayscale for opposite of theme
-  $kbnMarkdownAlphaLightestShadeReversed: rgba($euiColorEmptyShade,.05);
-  $kbnMarkdownAlphaLightShadeReversed: rgba($euiColorEmptyShade,.15);
-  $kbnMarkdownAlphaDarkShadeReversed: rgba($euiColorEmptyShade,.65);
+  $kbnMarkdownAlphaLightestShadeReversed: rgba($euiColorEmptyShade, .05);
+  $kbnMarkdownAlphaLightShadeReversed: rgba($euiColorEmptyShade, .15);
+  $kbnMarkdownAlphaDarkShadeReversed: rgba($euiColorEmptyShade, .65);
 
   &--reversed {
     color: $euiColorLightestShade;
@@ -183,7 +182,7 @@ $kbnDefaultFontSize: 14px;
   // 6. Lists
   ul,
   ol {
-    padding-left: 0;
+    padding-left: $kbnMarkdownSizeL;
     margin-top: 0;
     margin-bottom: $kbnMarkdownSize;
   }
@@ -215,11 +214,6 @@ $kbnDefaultFontSize: 14px;
     margin-left: 0;
   }
 
-  ul,
-  ol {
-    padding-left: $kbnMarkdownSizeL;
-  }
-
   ul ul,
   ul ol,
   ol ol,

src/plugins/timelion/public/_base.scss

@@ -16,4 +16,3 @@ input[type='checkbox'],
     opacity: .8;
   }
 }
-

src/plugins/timelion/public/directives/_index.scss

@@ -5,4 +5,3 @@
 @import './timelion_interval/index';
 @import './saved_object_finder';
 @import './form';
-

src/plugins/timelion/public/directives/_saved_object_finder.scss

@@ -24,7 +24,6 @@
   }
 }
 
-
 saved-object-finder {
 
   .timSearchBar {

src/plugins/timelion/public/directives/cells/_cells.scss

@@ -18,7 +18,6 @@
   opacity: .5;
 }
 
-
 .timCell__actions {
   position: absolute;
   bottom: $euiSizeXS;

src/plugins/vis_type_table/public/legacy/_table_vis.scss

@@ -12,7 +12,7 @@
 
 .table-vis-container {
   kbn-agg-table-group > .table > tbody > tr > td {
-    border-top: 0px;
+    border-top: 0;
   }
 
   .pagination-other-pages {

src/plugins/vis_type_timeseries/public/application/_tvb_editor.scss

@@ -2,4 +2,3 @@
   overflow-y: auto;
   overflow-x: hidden;
 }
-

src/plugins/vis_type_timeseries/public/application/components/vis_types/markdown/_markdown.scss

@@ -29,5 +29,3 @@
     overflow: auto;
   }
 }
-
-

src/plugins/vis_type_timeseries/public/application/visualizations/views/_top_n.scss

@@ -1,5 +1,4 @@
 
-
 .tvbVisTopN {
   position: relative;
   overflow: auto;

src/plugins/vis_type_vega/public/components/vega_vis.scss

@@ -110,7 +110,6 @@
   color: makeHighContrastColor($euiColorDanger, $calculateBackgroundColor);
 }
 
-
 // Style tooltip popup (gets created dynamically at the top level if dashboard has a Vega vis)
 // Adapted from https://github.com/vega/vega-tooltip
 

src/plugins/vis_type_vislib/public/vislib/lib/_index.scss

@@ -1,3 +1,2 @@
 @import './alerts';
 @import './layout/index';
-