Skip to content

Conversation

gitstashpop
Copy link
Contributor

Setrans fails silently by returning the original label if a level cannot
be translated. Instead, go-setrans will now notify users if an error
occurs.

Setrans fails silently by returning the original label if a level cannot
be translated. Instead, go-setrans will now notify users if an error
occurs.
@gitstashpop gitstashpop force-pushed the verify-successful-trans branch from dccd7dc to 73267db Compare October 26, 2020 14:33
@gitstashpop
Copy link
Contributor Author

gitstashpop commented Oct 26, 2020

@jbrindle I just realized that if you pass a valid pre-translated label to one of these calls, we'll now get an error. Is that desirable? Is this just something the caller should validate?

edit: we spoke offline, and decided to implement new functions with the desired behavior. That way we'll keep feature parity with libselinux/mcstrans with the existing functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant