Implemented max_docs #62
Conversation
Per issue jboynyc#56, implemented max_docs to allow easier ignoring of common terms. Updated network.py and documentation.
|
Just realised this pull request failed some checks, should be linted correctly now. If I need to fix anything else just let me know! |
|
Poetry confuses me - I generated a poetry.lock file via poetry lock --no-update though this caused conflicts. I don't see any reason why the code changes should have directly or indirectly caused any dependency changes. So, if I did it correctly, I just grabbed the existing upstream poetry.lock file. Reliant on your expertise here for if this is the right action. |
|
@jboynyc Anything else I need to do or fix here? Hope you are well! |
|
sorry, I've just been very busy with other work! I will prepare a new release with this soon. |
|
Added to the dev branch in 3226642 for inclusion in next release. Thanks again! |
|
Cheers @jboynyc. I would flag that it is acceptable for min_docs to equal max_docs? Benefit is marginal but it does allow one to filter to an exact frequency - potentially having niche application. |
|
Makes sense, I hadn't considered that! I'll change it back before the release. |
Per issue #56, implemented max_docs to allow easier ignoring of common terms. Updated network.py and documentation.