RingGenerator does not use the default node model

[acasteigts]

When executing the following code:

Topology topology = new Topology();
topology.setDefaultNodeModel(MyNode.class);
new RingGenerator(N).generate(topology);

the created nodes are not of type MyNode, but of class Node.

It is possible that the other generators have the same problem.

[remikey]

@acasteigts, as you mentioned in another thread, TopologyGenerators.generateRing() uses the proper model.

The "issue" comes from the fact that the RingGenerator, as any child of AbstractGenerator, separately stores a nodeClass which defaults on Node.class. It is modified via AbstractGenerator.setNodeClass() which is properly used by TopologyGenerators.generateRing().

I am not sure if we really want to remove the AbstractGenerator's capability to use "non-default".

[remikey]

This being said, AbstractGenerator could be notified rather easily, to try and get the Topology's default node model if none has been set using AbstractGenerator.setNodeClass().

[remikey]

I suppose we could postpone the decision on this issue.
Moreover, the following "workaround" should work:

RingGenerator generator = new RingGenerator(nbNodes);
[...]
generator.setNodeClass(RedNode.class);
generator.generate(topology);

What do you think?

[acasteigts]

OK to postpone the decision on RingGenerator and use TopologyGenerators.generateRing() instead for some time.

Now, I feel like setNodeClass() in AbstractGenerator is definitely redundant with setDefaultNodeModel() in Topology. Note that several models can also be registered using various names directly in the Topology.

I do not mind keeping setNodeClass() in AbstractGenerator so long as the default node model of the Topology is taken into account without any additional action from the user.

[remikey]

I have made a proposition on branch fix/110-ringgenerator-default-node. I will try and create a PR, for practice purpose.