[Experimental] - Integration tests refactor #304
Conversation
|
this is an experiment, feedback welcome but not to be applied yet |
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
it we are using the word itests why not use that in here too and just call it org.jboss.ide.eclipse.as.itests ? simpler, shorter and more unified ?
|
another concern with seperate itests...what does this mean for the test updatesite generated ? will it have test + itest combined ? |
|
...and any idea on how to actually build this branch since it does not at the moment. Seems feature.xml has crossing/missing dependencies to can't build from root. |
|
As i understand it, the current setup in the branch will skip only executing the tests based on the flag. It will still build the test plugins, and still package them into the update site, without any problems at all. the skip refers only to the running of the tests, and so it functions just as we'd want it to |
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.tycho</groupId> |
There was a problem hiding this comment.
remove this and the tests can be found again.
Why are you adding this here?
try run with 'mvn help:effective-pom' and you'll see for some reason it is not including things multiple times.
not sure why that make it not run - but dont grok why this is needed here.
There was a problem hiding this comment.
The other two integration plugins both have nearly identical lines in their poms and they run fine. It makes absolutely no sense that in this plugin they wont run but in the other two they do.
|
all-tests/pom.xml does not include all tests now thre is an itests folder. |
robstryker
force-pushed
the
integration_tests
branch
from
cfae677 to
605ec60
Compare
|
I've rebased against new version strings in master (upversioned the various modules) and squashed all the commits bc the log was becoming gigantic and full of temporary commits for communication / debugging with team members. |
| @@ -23,6 +34,35 @@ | |||
| <module>site</module> | |||
| </modules> | |||
|
|
|||
| <profiles> | |||
| <!-- used to set default when running in JBoss Jenkins --> | |||
| <profile> | |||
There was a problem hiding this comment.
I suppose for discussion purposes and to see if it is the type of profile we'd like to move up into parent pom.
robstryker
force-pushed
the
integration_tests
branch
2 times, most recently
from
bbdd922 to
dffae7c
Compare
rebase against master new version Update new test plugins / itests with new master version all-tests needs to reference the new itests folder Remove useless test plugin as.ui.test - had only one very very badly written test that was useless Rename mgmt test plugin, rename / move fred's tomcat tests into itests Rename mgmt test plugin, rename / move fred's tomcat tests into itests Problem with renamed mgmt test bundle; wrong bundle id constant used change itest flag name Test takes too long validating, freezes Fixing tomcat verification of the jre argument JBIDE-18765 - integration test refactor
robstryker
force-pushed
the
integration_tests
branch
from
dffae7c to
425ed3c
Compare
|
Rebased and squashed. This PR is ready to go. Just need a final +1. The following 3 commands work as expected: mvn clean verify -DskipTests skips all tests |
…t pom's default patterns
|
+1, because. |
| <!-- skipPrivateRequirements is inherited from parent pom --> | ||
|
|
||
| <!-- jbosstools.test.jre.7 is defined in root pom for convenience of reuse --> | ||
| <systemProperties> -Djbosstools.test.jre.6=${jbosstools.test.jre.6} -Djbosstools.test.jre.7=${jbosstools.test.jre.7} -Djbosstools.test.jre.8=${jbosstools.test.jre.8} -Djbosstools.test.jboss.home.3.2=${jbosstools.test.jboss.home.3.2} -Djbosstools.test.jboss.home.4.0=${jbosstools.test.jboss.home.4.0} -Djbosstools.test.jboss.home.4.2=${jbosstools.test.jboss.home.4.2} -Djbosstools.test.jboss.home.5.0=${jbosstools.test.jboss.home.5.0} -Djbosstools.test.jboss.home.5.1=${jbosstools.test.jboss.home.5.1} -Djbosstools.test.jboss.home.6.0=${jbosstools.test.jboss.home.6.0} -Djbosstools.test.jboss.home.7.0=${jbosstools.test.jboss.home.7.0} -Djbosstools.test.jboss.home.7.1=${jbosstools.test.jboss.home.7.1} -Djbosstools.test.jboss.home.8.0=${jbosstools.test.jboss.home.8.0} -Djbosstools.test.jboss.home.8.1=${jbosstools.test.jboss.home.8.1} -Djbosstools.test.jboss.home.eap.4.3=${jbosstools.test.jboss.home.eap.4.3} -Djbosstools.test.jboss.home.eap.5.0=${jbosstools.test.jboss.home.eap.5.0} -Djbosstools.test.jboss.home.eap.6.0=${jbosstools.test.jboss.home.eap.6.0} -Djbosstools.test.jboss.home.eap.6.1=${jbosstools.test.jboss.home.eap.6.1} -Djbosstools.test.jboss.home.eap.6.2=${jbosstools.test.jboss.home.eap.6.2} -Djbosstools.test.jboss.home.eap.6.3=${jbosstools.test.jboss.home.eap.6.3} -Dorg.jboss.tools.tests.skipPrivateRequirements=${skipPrivateRequirements} </systemProperties> |
There was a problem hiding this comment.
not sure why I did not notice this before.
But does the above not override any setup there might otherwise be in parent pom ? would it not be better to have a "additionalSystemProperties" components setup instead of completely overwriting/duplicating what the parent pom will set ?
There was a problem hiding this comment.
just checked parent pom and systemProperties actually already functions like that thus the above is a moot point.
|
+1 for this together with this jbosstools/jbosstools-devdoc#36 |
No description provided.