Convert various try blocks to try-with-resources #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibash
reviewed
Jul 17, 2021
| if (is != null) { | ||
| is.close(); | ||
| return con.getURL(); | ||
| try (InputStream is = con.getInputStream()) { |
There was a problem hiding this comment.
The try-with-resources will automatically close the stream just prior to the return. Thus, to my knowledge, the only differences between these versions are (1) closing after the getURL call vs before which should be fine from what I can tell and (2) the new version ensure the stream is closed no matter what where the old version could allow a scenario where the stream is not closed if the current thread is interrupted by an asynchronous exception before the close method is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.