Add support for DCE style authentication. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 98.30% 99.77% +1.46%
==========================================
Files 31 31
Lines 5262 5387 +125
==========================================
+ Hits 5173 5375 +202
+ Misses 89 12 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jborean93
force-pushed
the
dce
branch
2 times, most recently
from
2f32a2d to
895572a
Compare
Adds support for DCE style authentication that is used by protocols like RPC. DCE style authentication changes some behaviour about an authentication protocol, e.g. Kerberos has an extra leg, and some wrapping behaviour changes. This PR also adjusts the underlying behaviour of `spnego.iov.BufferType.sign_only` on SSPI to represent the buffer type of `SECBUFFER_DATA | SECBUFFER_READONLY_WITH_CHECKSUM` rather than `SECBUFFER_MECHLIST`. This aligns the behaviour with GSSAPI and the use of `SECBUFFER_MECHLIST` is most likely an internal flag rather than something used publicly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for DCE style authentication that is used by protocols like RPC. DCE style authentication changes some behaviour about an authentication protocol, e.g. Kerberos has an extra leg, and some wrapping behaviour changes. This PR also adjusts the underlying behaviour of
spnego.iov.BufferType.sign_onlyon SSPI to represent the buffer type ofSECBUFFER_DATA | SECBUFFER_READONLY_WITH_CHECKSUMrather thanSECBUFFER_MECHLIST. This aligns the behaviour with GSSAPI and the use ofSECBUFFER_MECHLISTis most likely an internal flag rather than something used publicly.