[jobs] Support ray client format of connection string address for ext…

…ernal module (ray-project#22116) Ray client currently supports connection strings for external modules of the format `"other_module://"`, however `ray job` commands don't support this format because trailing `/` is removed. Update so `ray job` commands also support this format.
jbn · Feb 4, 2022 · d9dc388 · d9dc388
1 parent 014a995
commit d9dc388
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/dashboard/modules/job/sdk.py b/dashboard/modules/job/sdk.py
@@ -98,7 +98,7 @@ def parse_cluster_info(
     metadata: Optional[Dict[str, Any]] = None,
     headers: Optional[Dict[str, Any]] = None,
 ) -> ClusterInfo:
-    module_string, inner_address = _split_address(address.rstrip("/"))
+    module_string, inner_address = _split_address(address)
 
     # If user passes http(s):// or ray://, go through normal parsing.
     if module_string in {"http", "https", "ray"}:

diff --git a/python/ray/tests/test_client_builder.py b/python/ray/tests/test_client_builder.py
@@ -21,6 +21,7 @@
         "localhost:1234",
         "localhost:1234/url?params",
         "1.2.3.4/cluster-1?test_param=param1?",
+        "",
     ],
 )
 def test_split_address(address):