Fix type_annotation_transforms for Sphinx 6 #181
Conversation
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
2 times, most recently
from
0f704a2 to
7faeee7
Compare
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
from
7faeee7 to
2837128
Compare
Instead of intercepting the call to `ast.parse`, we now parse, transform, and then unparse. This also drops support for Python 3.7, since Sphinx 6 also drops Python 3.7 support.
Previously, mypy issued the following warning regarding _render_body: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
from
2837128 to
fa5aac8
Compare
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
from
fa5aac8 to
47c3bc5
Compare
|
I think I've fixed all of the typing issues now. Unfortunately the setup-graphviz seems to be failing now on macOS, not sure how we can work around that. |
|
There seems to be a conflict between the installed python and the python homebrew tries to install. Although I can't clearly tell what the problem is. My instinct is to setup-graphviz before setup-python in the CI. |
|
We might be able to get graphviz through conda-forge instead of OS-specific pkg managers (like the current action does). |
|
Damn. I still have no idea what the problem is based on the homebrew output. |
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
from
5540102 to
1621013
Compare
jbms
force-pushed
the
fix-type_annotation_transforms-sphinx6
branch
from
1621013 to
6a4fe0b
Compare
|
I think this is a general issue with using homebrew on github actions. Reordering the graphviz step before the Python setup step did not fix the issue, but skipping |
|
Perhaps we should tag a new version with Sphinx 6 support? |
|
sure, but I was thinking a patch bump. |
No description provided.