Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RVA field alignment #888

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Fix RVA field alignment #888

merged 6 commits into from
Jan 18, 2023

Commits on Dec 27, 2022

  1. Fix RVA field alignment

    @sbomer
    sbomer committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    d65cda8 View commit details
    Browse the repository at this point in the history

  2. Use non-latest images to run tests

    @sbomer
    sbomer committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    34ffff4 View commit details
    Browse the repository at this point in the history

  3. Revert windows-2019 change

    @sbomer
    sbomer committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    51e9386 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Don't align code segment 

    This wasn't aligned to begin with. Attempting to align it causes problems
due to the way CodeWriter gets the code RVA - it computes the RVA
from the CLI Header length, which doesn't take into account the code's
alignment requirements.
    @sbomer
    sbomer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    9410f1e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Revert "Don't align code segment" 

    This reverts commit 9410f1e.
    @sbomer
    sbomer committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    df1a39e View commit details
    Browse the repository at this point in the history

  2. Keep alignment values for code

    @sbomer
    sbomer committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d4e7594 View commit details
    Browse the repository at this point in the history