Seamlessly support non-default-constructable custom class deserialization #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imple return type instead
…able custom types, while seamlessly supporting the old API; see Tutorial.mp for details
…able custom types, while seamlessly supporting the old API; see Tutorial.mp for details
… of clearer code structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API of the
convert<T>::decodeconstruct is limited to default constructable structs with visible members only. This is limiting and does not follow RAII.The here patch allows to declare in the custom 'struct convert' for any type
Ta decode method by slightly different, but more instructive, signatureT convert<T>::decode(const Node& node). Within that methodTcan be constructed by the user from the data serialized fromnodeand the result returned without the need to manipulate the members of an uninitialized reference. Problems in the deserialization process are marked by throwing theDecodeException, effectively replacing the old convoluted bool return signaling deserialization success.While users are free to implement this new API the old API is still supported in static code-path switches based on the
decode-signature detected.The complete documentation is found at the bottom of
docs/Tutorial.mdtests have been added and pass.
This patch closes #993
This patch also shows an alternative solution to merge request #1010