Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_prefix option for getters #23

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Add with_prefix option for getters #23

merged 2 commits into from
Mar 7, 2019

Conversation

Hoverbear
Copy link
Collaborator

Fix #22.

@Hoverbear Hoverbear self-assigned this Mar 5, 2019
nrc
nrc reviewed Mar 7, 2019
View reviewed changes
Copy link

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments inline

src/generate.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@Hoverbear
Check for with_prefix and rename a fn
4ad017b 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Copy link
Collaborator Author

@nrc Reflected. :)

nrc
nrc approved these changes Mar 7, 2019
View reviewed changes
Copy link

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hoverbear Hoverbear merged commit 262e842 into master Mar 7, 2019
@Hoverbear Hoverbear deleted the with_prefix branch March 7, 2019 20:00
@Hoverbear Hoverbear added this to the 0.0.7 milestone Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

@ice1000 ice1000 ice1000 approved these changes

Assignees

@Hoverbear Hoverbear

Labels
enhancement
Projects
None yet
Milestone
0.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @nrc @ice1000