fix: handle long command lines for .bat and .cmd #2035
Merged
+211
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quintesse
force-pushed
the
fix_2033
branch
3 times, most recently
from
95730a6 to
fd2b5da
Compare
maxandersen
previously approved these changes
May 28, 2025
|
looks good except for the ci failures ;) |
quintesse
force-pushed
the
fix_2033
branch
2 times, most recently
from
7c37ace to
eae4e17
Compare
Yeah yeah :-p Will you merge or shall I? |
On Windows when running command using Java's `ProcessBuilder` to run .bat or .cmd files we have to ensure that the command line does not exceed the maximum length allowed by the Windows command line. Fixes jbangdev#2033
|
Improved the PR by moving the Edit: also, right now the code still isn't perfect. If you are able to add more than 8Kb of source file names then it would still fail. But for now this should fix the most common cases. |
The Groovy compiler doesn't handle long command lines well. It supports `@argfiles` but only for listing source files, not for options. Given the fact that the longest option tends to be the `-classpath` option, we can use the `CLASSPATH` environment variable to shorten the command line.
maxandersen
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows when using Java's
ProcessBuilderto run .bat or .cmd files we have to ensure that the command line does not exceed the maximum length allowed by the Windows command line.Fixes #2033