feat: Jdks now indicate if their version is fixed or not #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to easily distinguish Jdks that represent fixed installations from those that can be made to point to different Jdks at different times (by us or by events outside our control).
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the JDK management functionality by introducing a fixedVersion flag to indicate whether a JDK version is fixed or dynamic. The changes update the createJdk methods across various providers, adjust test cases to verify the flag, and extend the Jdk interface along with its Default implementation.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/dev/jbang/devkitman/jdkproviders/MockJdkProvider.java | Updated createJdk calls to include a fixedVersion boolean (set to true) |
| src/test/java/dev/jbang/devkitman/TestJdkManager.java | Added assertions to test the fixedVersion flag of JDKs |
| src/main/java/dev/jbang/devkitman/jdkproviders/PathJdkProvider.java | Updated createJdk call with fixedVersion set to false |
| src/main/java/dev/jbang/devkitman/jdkproviders/LinkedJdkProvider.java | Added an overload of createJdk with fixedVersion parameter (false) |
| src/main/java/dev/jbang/devkitman/jdkproviders/JavaHomeJdkProvider.java | Updated createJdk call with fixedVersion set to false |
| src/main/java/dev/jbang/devkitman/jdkproviders/JBangJdkProvider.java | Updated createJdk call with fixedVersion set to true |
| src/main/java/dev/jbang/devkitman/jdkproviders/DefaultJdkProvider.java | Updated createJdk call with fixedVersion set to false |
| src/main/java/dev/jbang/devkitman/jdkproviders/CurrentJdkProvider.java | Updated createJdk call with fixedVersion set to false |
| src/main/java/dev/jbang/devkitman/jdkproviders/BaseFoldersJdkProvider.java | Added a new createJdk overload accepting a fixedVersion parameter |
| src/main/java/dev/jbang/devkitman/JdkProvider.java | Modified default createJdk method to accept the fixedVersion flag |
| src/main/java/dev/jbang/devkitman/JdkManager.java | Adjusted getOrInstallJdk methods and the default JDK setup to include the fixedVersion flag |
| src/main/java/dev/jbang/devkitman/Jdk.java | Updated the Jdk interface and its Default implementation to incorporate the fixedVersion property and related behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.