Preliminary refactoring #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 2, 2014 16:09
such as an incorrect schema in OrientDB : only default document types are visible, whereas all types should be.
To be able to process images in a correct fashion, markup engine can't be the base abstraction as it requires splitting the file as lines, which jpeg images have not.
It will allow image gallery generator to not read the lines of image file.
|
As soon as I'm back at home I'll review the changes properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to separate a little markup engine from the crawler code in order to insert jpeg engine into.
This change don't seems to break anything, and is only code move.