Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support thumbnail using width value only #569

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

avirepo
Copy link

@avirepo avirepo commented Oct 17, 2018

Supported for geometry_string value options widthx, xheight and widthxheight earlier it was not supporting widthx

eg:- 1. 400x600 (resize image with width 400 and height 600)
2. 400x (resize image with width 400 and keep height in proportion to original image)
3 x600 (resize image with height 600 and keep width in proportion to original image)

# Supported for geometry_string value options widthx, xheight and widthxheight earlier it was not supporting widthx
eg:- 1. 400x600 (resize image with width 400 and height 600)
2. 400x (resize image with width 400 and keep height in proportion to original image)
3 x600 (resize image with height 600 and keep width in proportion to original image)
@coveralls
Copy link

coveralls commented Oct 17, 2018

Coverage Status

Coverage remained the same at ?% when pulling 04ef7b5 on avirepo:master into 22ccd97 on jazzband:master.

@avirepo
Copy link
Author

avirepo commented Oct 24, 2018

Coverage Status

Coverage remained the same at ?% when pulling 0ddf497 on avirepo:master into 47cc30d on jazzband:master.

what to change in it as I have modified only regular expression

@claudep
Copy link
Contributor

claudep commented Aug 8, 2022

If anyone wants to revive this PR, tests are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants