-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent dry-run log message from being printed with --quiet option #861
Conversation
I'm not overly happy with tests needing to handle a |
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 99.06% 98.84% -0.23%
==========================================
Files 35 35
Lines 2142 2158 +16
Branches 284 284
==========================================
+ Hits 2122 2133 +11
- Misses 12 15 +3
- Partials 8 10 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 99.06% 98.93% -0.14%
==========================================
Files 35 35
Lines 2142 2152 +10
Branches 284 284
==========================================
+ Hits 2122 2129 +7
- Misses 12 14 +2
- Partials 8 9 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ddormer,
Thanks for the contribution! Could you please fix several issues in tests?
By the way it also refs to #845 and partially fixes it. |
Thanks for the review @atugushev. Sorry this took so long to get back to, I was on holiday the past week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts! LGTM 👍
|
Changed the log level for the message "Dry-run, so nothing updated." from
warning
toinfo
.Refs #845
Changelog-friendly one-liner: Prevent --dry-run log message from being printed with --quiet option.
Contributor checklist