Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text of resolver warning #1776

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Improve text of resolver warning #1776

merged 2 commits into from
Dec 14, 2022

Conversation

StevenMaude
Copy link
Contributor

@StevenMaude StevenMaude commented Dec 14, 2022 •
edited by atugushev
Loading

Improve the text of the resolver warning to clarify the warning's cause and fix the grammar.

Contributor checklist
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@StevenMaude
Improve text of resolver warning
93f35a4 
* Correct the grammar.
* Make the source of the warning clearer to the reader.
atugushev
atugushev approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StevenMaude
Copy link
Contributor Author

(As my edits made the strings longer than Black's line length, this change is formatted using black --preview to use Black's experimental string processing feature. This is why the trailing spaces changed to leading spaces: because of this autoformatting.)

@atugushev atugushev added the skip-changelog Avoid listing in changelog label Dec 14, 2022
@StevenMaude
Correct resolver warning in test
86c7315 
To match the updated warning.
@atugushev atugushev enabled auto-merge (squash) December 14, 2022 13:13
@atugushev atugushev merged commit 2aebb64 into jazzband:main Dec 14, 2022
@atugushev atugushev added the logging Related to log or console output label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
logging Related to log or console output skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenMaude @atugushev