Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test: ignore unavailable versions in preexisting output #1774

Conversation

AndydeCleyre
Copy link
Contributor

Before running pip-compile, the output file may contain a pinned requirement which can't be found in PyPI or whichever repo (e.g. a revoked release). This test checks that we gracefully discard these un-find-able pins, rather than cause the compile operation to fail.

The test only succeeds with the backtracking resolver, and is marked as xfail for legacy.

Related:

I think it would be appropriate to label this with skip-changelog.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Rather than fail and exit early,
it's better to discard these items.

The legacy resolver does not pass,
and there is no plan to fix that before
we drop that resolver completely.
@atugushev atugushev added tests Testing and related things skip-changelog Avoid listing in changelog labels Dec 13, 2022
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
@AndydeCleyre AndydeCleyre force-pushed the feature/test-ignore-compiled-unavailable-version branch from 81832e4 to 601b5c4 Compare December 13, 2022 18:59
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atugushev atugushev merged commit e085800 into jazzband:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants