Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --add-package/-A pip-compile flag #1742

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntjess
Copy link

@ntjess ntjess commented Nov 21, 2022

See #1730 for context. This new flag allows specifying packages on the command line instead of forcing them to come from a requirements file. May offer improved usage compared to piping from stdin as described in the linked issue.

Let me know your thoughts 🙂

(I'm waiting to add tests until after I hear whether the implementation is favorable compared to e.g. using a different flag name, supplementing pip-args, etc.)

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@@ -416,6 +426,9 @@ def cli(
upgrade_install_reqs = {
key_from_ireq(install_req): install_req for install_req in upgrade_reqs_gen
}
# Similar procedure for --add-package/-E but the key is not needed since
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-E in this comment should be -A.

@chrysle chrysle added feature Request for a new feature cli Related to command line interface things labels May 21, 2023
@chrysle
Copy link
Contributor

chrysle commented May 22, 2023

You need to rebase your pull request on current HEAD. The behavior of resolving packages to upgrade has been adjusted in #1578

@chrysle chrysle added the needs rebase Need to rebase or merge label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line interface things feature Request for a new feature needs rebase Need to rebase or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants