Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip>=21.3 #1501

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 10, 2021

Changes:

  • fix removed in pypa/pip@d051a00 pip._internal.utils.misc.get_installed_distributions used in piptools.scripts.sync

TODO:

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Fixes #1503

@atugushev
Copy link
Member Author

atugushev commented Oct 10, 2021

@AndydeCleyre I've prepared pip-tools for the upcoming pip-21.3 release (due date - 6:30pm UK time on Monday, Oct 11). Kindly requesting some assistance with review/merge TODOs 🙏🏻

@atugushev atugushev added this to the 6.4.0 milestone Oct 10, 2021
@atugushev atugushev added the enhancement Improvements to functionality label Oct 10, 2021
@atugushev atugushev marked this pull request as ready for review October 12, 2021 08:34
@atugushev
Copy link
Member Author

@jazzband/pip-tools now this is all set up and ready for review.

@ssbarnea ssbarnea self-requested a review October 12, 2021 12:08
@atugushev atugushev merged commit c95e188 into jazzband:master Oct 12, 2021
@atugushev
Copy link
Member Author

Thanks @ssbarnea 🙏🏻

@atugushev atugushev deleted the support-pip-21.3 branch October 12, 2021 12:10
@ssbarnea
Copy link
Member

Nopb. I was bit confused by the fact the pip version bumping was merged before that change but no problem. I hope to see this released ASAP as I do not want to have to update deps to avoid errors (or pin down pip).

@atugushev
Copy link
Member Author

@ssbarnea release is on the way #1504

@@ -3,6 +3,7 @@
import json
import os
import shlex
import typing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm late, but importing typing directly (and later using typing.Union rather than just Union) seems unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍🏻

@rrauenza
Copy link

thanks for the super quick fix, everyone! Saw this breaking across my cicd's and I was beginning to pin pip version...

@wizpig64 wizpig64 mentioned this pull request May 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-sync fails to run on pip >= 21.3
4 participants