Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to setuptools declarative syntax through setup.cfg #1141

Merged
merged 1 commit into from
May 9, 2020
Merged

Switch to setuptools declarative syntax through setup.cfg #1141

merged 1 commit into from
May 9, 2020

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented May 9, 2020

Avoids mixing code and configuration. This approach can allow for some
automation and also reduces boilerplate in setup.py.

Available since setuptools 30.3.0 (Dec 8, 2016).

https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

Switch to setuptools declarative syntax through setup.cfg

Contributor checklist
  • Provided the tests for the changes. (N/A)
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Avoids mixing code and configuration. This approach can allow for some
automation and also reduces boilerplate in setup.py.

Available since setuptools 30.3.0 (Dec 8, 2016).

https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files
@auvipy auvipy added this to the 5.2.0 milestone May 9, 2020
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #1141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          37       37           
  Lines        2678     2678           
  Branches      322      322           
=======================================
  Hits         2664     2664           
  Misses          8        8           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59511b...db3cb74. Read the comment docs.

@auvipy auvipy merged commit 15d5201 into jazzband:master May 9, 2020
@atugushev atugushev added the packaging Packaging related stuff label May 27, 2020
@jdufresne jdufresne deleted the setup-cfg branch November 15, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Packaging related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants