Auto Update Locale Files #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be updated and clean up the workflow with newer dependencies including:
python 3.9 -> 3.12
GH action/checkout@v2 -> action/checkout@v4
create-pull-request@v3 -> create-pull-requests@v6
actions/setup-python@v2 -> actions/setup-python@v5
With the updated dependencies we now cache python dependencies with the built-in functionality.
We also only run this action if it's push to the jazzband org repo
dpgraham4401
force-pushed
the
locale_auto_update
branch
from
d4ff126 to
8a80dbc
Compare
50-Course
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
thanks for sending in this patch! the approach to validate only against upstream is a very nice idea!
Good work @dpgraham4401 🚀
|
@aqeelat I've responded. Sorry I haven't thought about this PR in a couple months so I've forgotten a lot about the implementation details. Happy to make modifications. |
|
I'd say let's give it a shot. Thanks so much @dpgraham4401 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update workflow permissions to automatically create a PR to trunk (master/main) when locale files need to be updated. It also cleans up the existing workflow with newer dependencies including:
With the updated dependencies we now cache python dependencies with the built-in functionality instead of doing so manually.
We also only run this action if it's push to the jazzband org repo
This PR closes #462