-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions. #340
Conversation
This also gets rid of the duplicate test setup with the Makefile/profile. Tox is the way to go.
I'm currious of why removing the Makefile though? |
Not a huge reason other than Makefiles tend to collect dust and it doesn't map to the tox config as nicely, adding duplication. I can re-add it though, no strong feelings other than "let's get this migrated". |
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage ? 88.50%
=========================================
Files ? 6
Lines ? 287
Branches ? 50
=========================================
Hits ? 254
Misses ? 15
Partials ? 18 Continue to review full report at Codecov.
|
@Natim I've added a separate workflow for running pre-commit but wondered if you'd be interested in trialing the use of https://pre-commit.ci? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this. I'm not yet familiar with GH actions, so I'm mostly trusting you!
Thank you, this is a pretty conservative way to do GitHub Actions, and we have now ~40 other Jazzband projects doing a very similar setup. I'm a bit more skeptical to have a 3rd party service for pre-commit (since it's what has screwed us with Travis CI), but since it's from the pre-commit author I think it may be worth a shot. |
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
Fix #329.
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.