Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #340

Merged
merged 8 commits into from
Mar 10, 2021
Merged

Migrate to GitHub Actions. #340

merged 8 commits into from
Mar 10, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Jan 28, 2021

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

Fix #329.

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

This also gets rid of the duplicate test setup with the Makefile/profile. Tox is the way to go.
@Natim
Copy link
Collaborator

Natim commented Jan 28, 2021

I'm currious of why removing the Makefile though?

@jezdez
Copy link
Member Author

jezdez commented Jan 28, 2021

I'm currious of why removing the Makefile though?

Not a huge reason other than Makefiles tend to collect dust and it doesn't map to the tox config as nicely, adding duplication. I can re-add it though, no strong feelings other than "let's get this migrated".

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b73c832). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #340   +/-   ##
=========================================
  Coverage          ?   88.50%           
=========================================
  Files             ?        6           
  Lines             ?      287           
  Branches          ?       50           
=========================================
  Hits              ?      254           
  Misses            ?       15           
  Partials          ?       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73c832...5e8e40c. Read the comment docs.

@jezdez
Copy link
Member Author

jezdez commented Jan 28, 2021

@Natim I've added a separate workflow for running pre-commit but wondered if you'd be interested in trialing the use of https://pre-commit.ci?

@jezdez jezdez requested a review from Natim January 28, 2021 17:28
@jezdez jezdez requested a review from claudep January 28, 2021 17:31
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this. I'm not yet familiar with GH actions, so I'm mostly trusting you!

@jezdez
Copy link
Member Author

jezdez commented Jan 28, 2021

Thanks a lot for working on this. I'm not yet familiar with GH actions, so I'm mostly trusting you!

Thank you, this is a pretty conservative way to do GitHub Actions, and we have now ~40 other Jazzband projects doing a very similar setup. I'm a bit more skeptical to have a 3rd party service for pre-commit (since it's what has screwed us with Travis CI), but since it's from the pre-commit author I think it may be worth a shot.

@jezdez jezdez merged commit 9175803 into master Mar 10, 2021
@jezdez jezdez deleted the gha branch March 10, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from Travis for CI
3 participants