Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #703

Merged
merged 9 commits into from
Dec 21, 2020
Merged

Migrate to GitHub Actions. #703

merged 9 commits into from
Dec 21, 2020

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Dec 21, 2020

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

It drops support for Python 3.5 because it's EOL.

Python 3.9 support is also added.

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #703 (d15be01) into master (1e4dca3) will decrease coverage by 3.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   94.67%   91.43%   -3.25%     
==========================================
  Files           3        3              
  Lines         432      432              
  Branches       78       78              
==========================================
- Hits          409      395      -14     
- Misses         14       23       +9     
- Partials        9       14       +5     
Impacted Files Coverage Δ
taggit/managers.py 90.77% <0.00%> (-4.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4dca3...d15be01. Read the comment docs.

Copy link
Member

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The dropping of Python 3.5 support should be added to the CHANGELOG.rst

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

Copy link
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions on the tox.ini configuration.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
jezdez and others added 3 commits December 21, 2020 20:34
Co-authored-by: Aleksi Häkli <aleksi.hakli@iki.fi>
Co-authored-by: Aleksi Häkli <aleksi.hakli@iki.fi>
Co-authored-by: Aleksi Häkli <aleksi.hakli@iki.fi>
@jezdez
Copy link
Member Author

jezdez commented Dec 21, 2020

Thanks all for the reviews! 😍

@jezdez jezdez merged commit b08ed6d into master Dec 21, 2020
@jezdez jezdez deleted the gha branch December 21, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants