Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 1.9 support #197

Merged
merged 6 commits into from
Nov 30, 2015
Merged

Add Django 1.9 support #197

merged 6 commits into from
Nov 30, 2015

Conversation

macro1
Copy link
Collaborator

@macro1 macro1 commented Nov 9, 2015

This should make everything work with Django 1.9. I also turned on warnings output to console when running the tests directly with runtests.py, and addressed some future warnings for 1.10. The changes didn't seem significant enough to drop 1.4 support, but we should consider doing it on the next minor release.

@sgallen
Copy link

sgallen commented Nov 20, 2015

What's the status on 1.9 support and this PR? Just curious, if it's likely to be merged soon. I'm starting a new Django 1.9 project and I'm looking to include django-simple-history.

@macro1
Copy link
Collaborator Author

macro1 commented Nov 21, 2015

The work is done... I just need to find some time to wrap up a release and
get it pushed into pypi
On Nov 20, 2015 11:51 AM, "Scott Allen" notifications@github.com wrote:

What's the status on 1.9 support and this PR? Just curious, if it's likely
to be merged soon. I'm starting a new Django 1.9 project and I'm looking to
include django-simple-history.


Reply to this email directly or view it on GitHub
#197 (comment)
.

macro1 added a commit that referenced this pull request Nov 30, 2015
@macro1 macro1 merged commit 4492802 into master Nov 30, 2015
@macro1 macro1 deleted the django19 branch November 30, 2015 01:55
@gabn88
Copy link
Contributor

gabn88 commented Jun 26, 2016

I still get:

simple_history/models.py:133: RemovedInDjango19Warning: Model class address.abstract_models.HistoricalUserInformation doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.
type(str(name), self.bases, attrs))

When using inherit=True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants