Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no DataCollector().request then don't wrap sql queries #320

Merged
merged 1 commit into from
Mar 8, 2019
Merged

If there is no DataCollector().request then don't wrap sql queries #320

merged 1 commit into from
Mar 8, 2019

Conversation

rwlogel
Copy link

@rwlogel rwlogel commented Dec 11, 2018

This is a potential fix for issue #319

auvipy
auvipy suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a failing test to verify the proposed change? beside try to make travis green :)

@rwlogel
Copy link
Author

rwlogel commented Mar 4, 2019

I updated the unit tests to account for the changes.

@auvipy auvipy merged commit 1d2968c into jazzband:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwlogel @auvipy