Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix alternative github tags installation url #243

Merged
merged 1 commit into from
Dec 28, 2017
Merged

fix alternative github tags installation url #243

merged 1 commit into from
Dec 28, 2017

Conversation

dennybiasiolli
Copy link
Contributor

@dennybiasiolli dennybiasiolli commented Dec 28, 2017 •
edited
Loading

allowing direct installation via a single pip install command.

Thanks to @xrmx for the suggestion

@albertyw albertyw self-requested a review December 28, 2017 13:51
albertyw
albertyw approved these changes Dec 28, 2017
View reviewed changes
Copy link
Member

@albertyw albertyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now until #187 gets released. I don't think we want to support this long-term since jazzband is a pretty open org and installing directly from github is a bit of a security risk.

@albertyw albertyw merged commit a424b51 into jazzband:master Dec 28, 2017
@dennybiasiolli dennybiasiolli deleted the patch-1 branch December 28, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertyw albertyw albertyw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennybiasiolli @albertyw