-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added django 4 to CI #580
Added django 4 to CI #580
Conversation
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
======================================
Coverage 57.8% 57.8%
======================================
Files 39 39
Lines 2497 2497
Branches 73 73
======================================
Hits 1441 1441
Misses 1041 1041
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WisdomPill , four things I noticed:
- Adding support for Django 4 seems uncontroversial, dropping 2.2 prior to EOL could be considered controversial by some; I'd split those in two pull requests personally
- The current title of the pull request does not mention dropping Django 2.2; my vote for adding that
- Django 3.1 is EOL even before Django 2.2 (see image below) but it is not being dropped; why not?
- Dropping of Django 2.2 seems to be incomplete, e.g. I still see a line
2.2: dj22
insetup.cfg
, maybe more.
Just my 2 cents.
PS: @WisdomPill there is indeed one more: |
my mistake, dropping 2.2 is a mistake the docs were saying that support for django 1.11 has dropped in april 2020 |
thanks @hartwork ! |
Fixes #579
Added support for django 4.0