Skip to content

1.4.1 release #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2021
Merged

1.4.1 release #940

merged 3 commits into from
Mar 12, 2021

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Mar 10, 2021

Fixes: #923

Description of the Change

A few minor changes. See CHANGELOG.md

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from MattBlack85 March 10, 2021 18:47
@n2ygk n2ygk added this to the 1.4.1 milestone Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #940 (a9808ae) into master (2555156) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   94.94%   95.07%   +0.13%     
==========================================
  Files          30       30              
  Lines        1423     1420       -3     
==========================================
- Hits         1351     1350       -1     
+ Misses         72       70       -2     
Impacted Files Coverage Δ
oauth2_provider/models.py 98.26% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2555156...a9808ae. Read the comment docs.

@n2ygk
Copy link
Member Author

n2ygk commented Mar 10, 2021

@MattBlack85 I just realized that I don't think we saw a resolution to #923. I don't want to hold up 1.5.0 for it, so I think we're OK without it for now?

@n2ygk
Copy link
Member Author

n2ygk commented Mar 11, 2021

@MattBlack85 I just realized that I don't think we saw a resolution to #923. I don't want to hold up 1.5.0 for it, so I think we're OK without it for now?

Fixed this with b5e2cd5

@MattBlack85
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-up to #906
3 participants