Skip to content

fix: codecov uploads failing #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Jul 11, 2025

codecov uploads are failing due to rate limiting
see: https://github.com/jazzband/django-oauth-toolkit/actions/runs/16092121891/job/45410281627#step:8:37 codecov/feedback#735 (comment) indicated I should try oidc

Description of the Change

enable oidc on codecov step of test job.

Checklist

  • PR only contains one change (considered splitting up PR)
  • [N/A] unit-test added
  • [N/A] documentation updated
  • [N/A] CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (8d3e7a9) to head (632f4d8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
- Coverage   97.38%   97.37%   -0.01%     
==========================================
  Files          34       34              
  Lines        2214     2212       -2     
==========================================
- Hits         2156     2154       -2     
  Misses         58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dopry dopry requested review from Copilot and n2ygk July 11, 2025 17:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enable OpenID Connect (OIDC) for Codecov uploads to avoid rate limiting errors.

  • Grant id-token: write permission for OIDC token retrieval
  • Upgrade codecov-action from v3 to v5 and enable use_oidc: true
Comments suppressed due to low confidence (2)

.github/workflows/test.yml:9

  • When you define a custom permissions block, it overrides defaults like contents: read. Add contents: read alongside id-token: write so actions/checkout and other steps still have repository read access.
    permissions:

.github/workflows/test.yml:65

  • [nitpick] Consider pinning to a specific patch release (e.g., @v5.3.1) instead of the floating @v5 tag to avoid unexpected breaking changes from future updates.
      uses: codecov/codecov-action@v5

@dopry
Copy link
Contributor Author

dopry commented Jul 11, 2025

@n2ygk I'd love to get this merged if you're okay with it so I can get pending PRs rebased on it to assert coverage changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant